Add FAB migration commands - #41804
Merged
Merged
Conversation
ephraimbuddy
marked this pull request as draft
August 27, 2024 18:08
ephraimbuddy
force-pushed
the
add-fab-upgrade-commands
branch
4 times, most recently
from
August 29, 2024 10:19
f7e2b2c to
0ef502a
Compare
ephraimbuddy
marked this pull request as ready for review
August 29, 2024 10:21
ephraimbuddy
force-pushed
the
add-fab-upgrade-commands
branch
from
August 29, 2024 13:07
0ef502a to
416a964
Compare
shahar1
reviewed
Aug 30, 2024
shahar1
left a comment
shahar1
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall, my main conerns are regarding having both changes to core and providers.
ephraimbuddy
force-pushed
the
add-fab-upgrade-commands
branch
from
August 30, 2024 10:10
416a964 to
f1915b4
Compare
ephraimbuddy
force-pushed
the
add-fab-upgrade-commands
branch
6 times, most recently
from
September 4, 2024 21:13
6ea9c9d to
e4d4bdd
Compare
ephraimbuddy
force-pushed
the
add-fab-upgrade-commands
branch
from
September 17, 2024 11:14
e4d4bdd to
b615aae
Compare
ephraimbuddy
force-pushed
the
add-fab-upgrade-commands
branch
from
September 18, 2024 09:44
2baf5a1 to
9242359
Compare
jedcunningham
approved these changes
Sep 18, 2024
This PR adds `migrate`, `upgrade` and `reset` db commands to facilitate migrating FAB DBs. FAB upgrade is also integrated into Airflow upgrade such that if airflow db is being upgraded to the heads, FAB migration will also upgrade to the heads. Migration checks to determine if migration has finished now includes checking that FAB migration is also done. Note that downgrading Airflow does not trigger FAB downgrade. FAB downgrade has to be done with FAB downgrade command.
ephraimbuddy
force-pushed
the
add-fab-upgrade-commands
branch
from
September 18, 2024 23:37
583dfee to
4c6cea7
Compare
jedcunningham
approved these changes
Sep 19, 2024
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* Add FAB migration commands This PR adds `migrate`, `upgrade` and `reset` db commands to facilitate migrating FAB DBs. FAB upgrade is also integrated into Airflow upgrade such that if airflow db is being upgraded to the heads, FAB migration will also upgrade to the heads. Migration checks to determine if migration has finished now includes checking that FAB migration is also done. Note that downgrading Airflow does not trigger FAB downgrade. FAB downgrade has to be done with FAB downgrade command. * Fix failing tests * Add tests * add more tests * fixup! add more tests * fixup! fixup! add more tests * Refactor code * fixup! Refactor code * set airflow_db as false * Add placeholder migration for correct stamping * fixup! Add placeholder migration for correct stamping * fixup! fixup! Add placeholder migration for correct stamping * fix test * fixup! fix test * fix rebase mistake * use reserialize_dags instead of airflow_db * add messages around placeholder migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
migrate,upgradeandresetdb commands to facilitate migrating FAB DBs.FAB upgrade is also integrated into Airflow upgrade such that if airflow db is being upgraded to the heads, FAB migration will also upgrade to the heads.
Migration checks to determine if migration has finished now includes checking that FAB migration is also done.
Note that downgrading Airflow does not trigger FAB downgrade. FAB downgrade has to be done with FAB downgrade command.