Skip to content

provider fab auth manager deprecated methods removed - #41720

Merged
vincbeck merged 4 commits into
apache:mainfrom
dirrao:deprecated_fab_auth_manager_methods_removal
Aug 26, 2024
Merged

provider fab auth manager deprecated methods removed#41720
vincbeck merged 4 commits into
apache:mainfrom
dirrao:deprecated_fab_auth_manager_methods_removal

Conversation

@dirrao

@dirrao dirrao commented Aug 25, 2024

Copy link
Copy Markdown
Contributor

provider fab auth manager deprecated methods removed

  1. get_readable_dags
  2. get_editable_dags
  3. get_accessible_dags
  4. get_accessible_dag_ids
  5. get_readable_dag_ids
  6. init_role
  7. prefixed_dag_id

@dirrao dirrao added airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes airflow3.0:candidate Potential candidates for Airflow 3.0 labels Aug 25, 2024
@dirrao
dirrao requested review from eladkal and potiuk August 25, 2024 06:03
@dirrao dirrao self-assigned this Aug 25, 2024

@jscheffl jscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static checks are failing, else good to merge.

@dirrao

dirrao commented Aug 26, 2024

Copy link
Copy Markdown
Contributor Author

Static checks are failing, else good to merge.

It's resolved.

@vincbeck
vincbeck merged commit b039183 into apache:main Aug 26, 2024
@eladkal

eladkal commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

This one is not handled properly... It mixes core and provider. Providers dont have newsfragments. It also force us to cut fab provider 2.0.0 is that something we want to do now? (We can but I am not sure we should). Initially I wanted to handle all providers deprecations together as bulk for 2.11

@potiuk

potiuk commented Sep 2, 2024

Copy link
Copy Markdown
Member

Yesl This one should be reverted.

potiuk added a commit to potiuk/airflow that referenced this pull request Sep 2, 2024
@potiuk

potiuk commented Sep 2, 2024

Copy link
Copy Markdown
Member

Revert PR here
#41960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes airflow3.0:candidate Potential candidates for Airflow 3.0 area:providers provider:fab

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants