provider fab auth manager deprecated methods removed - #41720
Merged
vincbeck merged 4 commits intoAug 26, 2024
Conversation
jscheffl
approved these changes
Aug 25, 2024
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
Static checks are failing, else good to merge.
Contributor
Author
It's resolved. |
vincbeck
approved these changes
Aug 26, 2024
Contributor
|
This one is not handled properly... It mixes core and provider. Providers dont have newsfragments. It also force us to cut fab provider 2.0.0 is that something we want to do now? (We can but I am not sure we should). Initially I wanted to handle all providers deprecations together as bulk for 2.11 |
Member
|
Yesl This one should be reverted. |
Member
|
Revert PR here |
potiuk
added a commit
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
provider fab auth manager deprecated methods removed