fix: reduce irrelevant error logs for pod events. - #37944
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:cncf-kubernetes
sudiptob2
force-pushed
the
fix/k8s-irrelevant-logs
branch
from
March 6, 2024 19:17
380628b to
7b17ad7
Compare
sudiptob2
marked this pull request as ready for review
March 6, 2024 19:18
2 tasks
Member
|
Looks good. Two comments:
|
sudiptob2
force-pushed
the
fix/k8s-irrelevant-logs
branch
2 times, most recently
from
March 6, 2024 21:38
226f58b to
b456308
Compare
sudiptob2
changed the title
sudiptob2
force-pushed
the
fix/k8s-irrelevant-logs
branch
from
March 6, 2024 22:36
3aa05e8 to
83b7756
Compare
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
sudiptob2
force-pushed
the
fix/k8s-irrelevant-logs
branch
from
March 6, 2024 22:39
83b7756 to
a253b98
Compare
Contributor
Author
|
@potiuk thanks for looking at the PR.
Added a unit test. |
Contributor
|
Looks good to me, nice work! |
potiuk
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #36077
Kubernetes pod Event API provides
typei.e.WarningandNormal. It is possible to logevent failuresinto different log levels using thistypeattribute.Ref: https://kubernetes.io/docs/reference/kubernetes-api/cluster-resources/event-v1/
Initial testing gives following output:
Test Dag: test_fail_dag_2
Output: