Add "MENU" permission in auth manager - #37881
Merged
Merged
Conversation
vincbeck
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
March 4, 2024 15:36
boring-cyborg
Bot
added
area:providers
area:webserver
Contributor
Author
o-nikolas
reviewed
Mar 4, 2024
jedcunningham
approved these changes
Mar 5, 2024
o-nikolas
approved these changes
Mar 5, 2024
potiuk
approved these changes
Mar 5, 2024
Contributor
Author
|
Merging. The test failure is unrelated to this PR |
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 89e7f3e)
14 tasks
sehaj-sandhu
added a commit
to acceldata-io/airflow
that referenced
this pull request
Jul 9, 2026
…024-28746) The auth manager collapsed ACTION_CAN_ACCESS_MENU into ACTION_CAN_READ (menu access treated as read access), so an authenticated low-privilege user could see menu items - and the resources behind them (Variables, Connections, Config, etc.) - without holding the menu-access permission. Backport of upstream commit 89e7f3e (apache#37881, fixed in 2.8.3), adapted to 2.8.1 layout (FAB auth manager lives under airflow/auth/managers/fab/, not airflow/providers/fab/): - base_auth_manager: add "MENU" to the ResourceMethod literal - utils/fab: map MENU -> ACTION_CAN_ACCESS_MENU, and stop aliasing ACTION_CAN_ACCESS_MENU back to "GET" - fab_auth_manager: is_authorized_view uses MENU for AccessView.DOCS; _get_user_permissions no longer rewrites CAN_ACCESS_MENU to CAN_READ - www/security_manager: custom-view check no longer aliases the two Pre-images matched 2.8.1 exactly; removed permission imports are unused after the change. Registered all four files in odp/patch_files.txt. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sehaj-sandhu
added a commit
to acceldata-io/airflow
that referenced
this pull request
Jul 10, 2026
…024-28746) The auth manager collapsed ACTION_CAN_ACCESS_MENU into ACTION_CAN_READ (menu access treated as read access), so an authenticated low-privilege user could see menu items - and the resources behind them (Variables, Connections, Config, etc.) - without holding the menu-access permission. Backport of upstream commit 89e7f3e (apache#37881, fixed in 2.8.3), adapted to 2.8.1 layout (FAB auth manager lives under airflow/auth/managers/fab/, not airflow/providers/fab/): - base_auth_manager: add "MENU" to the ResourceMethod literal - utils/fab: map MENU -> ACTION_CAN_ACCESS_MENU, and stop aliasing ACTION_CAN_ACCESS_MENU back to "GET" - fab_auth_manager: is_authorized_view uses MENU for AccessView.DOCS; _get_user_permissions no longer rewrites CAN_ACCESS_MENU to CAN_READ - www/security_manager: custom-view check no longer aliases the two Pre-images matched 2.8.1 exactly; removed permission imports are unused after the change. Registered all four files in odp/patch_files.txt. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
JeffreySmith
pushed a commit
to acceldata-io/airflow
that referenced
this pull request
Jul 27, 2026
JeffreySmith
pushed a commit
to acceldata-io/airflow
that referenced
this pull request
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.