Properly include airflow_pre_installed_providers.txt artifact - #37679
Merged
potiuk merged 1 commit intoFeb 24, 2024
Merged
Conversation
The "airflow_pre_installed_providers.txt" shoudl be included as artifact when preparing sdist package, because it is used by the hatch_build.py to post-process extras and make sure to add the pre-installed providers to wheel. However, the file was added in pyproject.toml without leading slash which caused that ANY airflow_pre_installed_providers.txt file in the sources root would be included. When you build source package with local hatch however, the file was actually copied to the out folder in order to create reproducible source package and the lack of slash made such file included as part of the produced sdist package (out directory is otherwise ignored by hatch due to .gitignore rules). That lead to a possibility that if you prepared tarball first and then packages using local hatch, the file would be included and sdist packages would not be binary identical. Adding leading slash eliminates the problem.
potiuk
requested review from
Taragolis,
eladkal,
ephraimbuddy,
jedcunningham,
josh-fell and
pankajkoti
February 24, 2024 19:03
Member
Author
|
edge-case of an edge-case :) |
eladkal
approved these changes
Feb 24, 2024
potiuk
deleted the
properly-include-installed-airflow-providers-artifact
branch
February 24, 2024 21:56
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 6, 2024
The "airflow_pre_installed_providers.txt" shoudl be included as artifact when preparing sdist package, because it is used by the hatch_build.py to post-process extras and make sure to add the pre-installed providers to wheel. However, the file was added in pyproject.toml without leading slash which caused that ANY airflow_pre_installed_providers.txt file in the sources root would be included. When you build source package with local hatch however, the file was actually copied to the out folder in order to create reproducible source package and the lack of slash made such file included as part of the produced sdist package (out directory is otherwise ignored by hatch due to .gitignore rules). That lead to a possibility that if you prepared tarball first and then packages using local hatch, the file would be included and sdist packages would not be binary identical. Adding leading slash eliminates the problem. (cherry picked from commit 2ac8abf)
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "airflow_pre_installed_providers.txt" shoudl be included as artifact when preparing sdist package, because it is used by the hatch_build.py to post-process extras and make sure to add the pre-installed providers to wheel.
However, the file was added in pyproject.toml without leading slash which caused that ANY airflow_pre_installed_providers.txt file in the sources root would be included. When you build source package with local hatch however, the file was actually copied to the out folder in order to create reproducible source package and the lack of slash made such file included as part of the produced sdist package (out directory is otherwise ignored by hatch due to .gitignore rules). That lead to a possibility that if you prepared tarball first and then packages using local hatch, the file would be included and sdist packages would not be binary identical.
Adding leading slash eliminates the problem.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.