AWS Batch Executor - #37618
Merged
Merged
Conversation
syedahsn
requested review from
ashb,
eladkal,
o-nikolas and
potiuk
as code owners
February 22, 2024 11:25
Taragolis
reviewed
Feb 26, 2024
Taragolis
left a comment
Contributor
There was a problem hiding this comment.
Minor things that I've found
vincbeck
approved these changes
Feb 26, 2024
Contributor
Author
o-nikolas
reviewed
Feb 27, 2024
o-nikolas
left a comment
Contributor
There was a problem hiding this comment.
I'm halfway through, but need to go for lunch, so I'm "committing" the first batch (no pun intended) of comments :)
Looking great so far!
o-nikolas
reviewed
Feb 27, 2024
…eExecutor and BatchExecutor launches Airflow tasks on AWS ECS/Fargate service and the AWS Batch service, respectively.
Rebase from main
Fix import statements order
-Apply recursive updates to exec_config parameter -Apply waits between each task retry attempt -Unit tests
Add doc string to functions
syedahsn
force-pushed
the
syedahsn/aws_executors_batch
branch
from
March 1, 2024 06:16
22e5407 to
a2e5d0b
Compare
Taragolis
approved these changes
Mar 2, 2024
Taragolis
left a comment
Contributor
There was a problem hiding this comment.
Looking good to me, if it take in account that executor has an experimental status
o-nikolas
approved these changes
Mar 4, 2024
Remove assert statement
Contributor
Author
|
Sorry I missed those! Added them now, thanks! |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Mar 6, 2024
potiuk
added a commit
that referenced
this pull request
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces the AWS Batch Executor. This Executor can be configured to run Airflow tasks using AWS Batch. It is based on an initial contribution from @aelzeiny.
From the README:
This PR comes with most features now included in the ECS Executor, but we will continue to update both executors as we work to improve them.
Review Notes
Similar to the ECS Executor, this PR comes as a fully functional feature, which is great for testing, but it does mean that the PR is large. When reviewing, it isn't necessary to go through every single line. Instead, it would be more beneficial to have read through the documentation, and glance at how the Executor is implemented.
There are a lot of similarities in the code between the Batch Executor and the ECS Executor - this is by design. As we continue to refine the process of writing custom Executors, we are converging on an optimal framework to write efficient, reliable, and fault-tolerant custom Executors.
Testing
There is extensive unit testing which has near 100% line coverage in most cases:

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.