Skip to content

Fix assignment of template field in __init__ in container_instances.py #36529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josh-fell merged 2 commits into from
Jan 15, 2024
Merged

Fix assignment of template field in __init__ in container_instances.py #36529

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e57c385
fix assignment of template variable
romsharon98 Jan 2, 2024
83afe89
remove unecessary lines
romsharon98 Jan 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions airflow/providers/microsoft/azure/operators/container_instances.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def __init__(

self.ci_conn_id = ci_conn_id
self.resource_group = resource_group
self.name = self._check_name(name)
self.name = name
Comment thread
romsharon98 marked this conversation as resolved.
Outdated
self.image = image
self.region = region
self.registry_conn_id = registry_conn_id
Expand Down Expand Up @@ -370,9 +370,6 @@ def _log_last(self, logs: list | None, last_line_logged: Any) -> Any | None:

@staticmethod
def _check_name(name: str) -> str:
if "{{" in name:
# Let macros pass as they cannot be checked at construction time
return name
regex_check = re.match("[a-z0-9]([-a-z0-9]*[a-z0-9])?", name)
if regex_check is None or regex_check.group() != name:
raise AirflowException('ACI name must match regex [a-z0-9]([-a-z0-9]*[a-z0-9])? (like "my-name")')
Expand Down