Feature/trino provider timezone - #35963
Merged
Merged
Conversation
romsharon98
force-pushed
the
feature/trino-provider-timezone
branch
from
November 29, 2023 21:04
d880799 to
fa33eb3
Compare
pgagnon
approved these changes
Nov 30, 2023
pgagnon
left a comment
pgagnon
left a comment
Contributor
There was a problem hiding this comment.
lgtm. I have a mini nitpick regarding the documentation (add a colon after "Example") but I wouldn't delay merging the PR to address this.
Lee-W
approved these changes
Dec 1, 2023
| verify=_boolify(extra.get("verify", True)), | ||
| session_properties=extra.get("session_properties") or None, | ||
| client_tags=extra.get("client_tags") or None, | ||
| timezone=extra.get("timezone") or None, |
Member
There was a problem hiding this comment.
nitpick: May I know if we need the or None here? I thought if "timezone" is not presented, it will return None by default.
Contributor
There was a problem hiding this comment.
I see that we have that in other parameters as well.
@romsharon98 can you check it and if needed handle it in a followup PR?
Co-authored-by: Philippe Gagnon <12717218+pgagnon@users.noreply.github.com>
eladkal
approved these changes
Dec 1, 2023
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continue this PR: #35147
With cherry picking @duyet
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.