Skip to content

Enhance DynamoDBValueSensor to support any attribute value in list - #35831

Merged
eladkal merged 1 commit into
apache:mainfrom
flolas:main
Nov 25, 2023
Merged

Enhance DynamoDBValueSensor to support any attribute value in list#35831
eladkal merged 1 commit into
apache:mainfrom
flolas:main

Conversation

@flolas

@flolas flolas commented Nov 24, 2023

Copy link
Copy Markdown
Contributor

This PR introduces an enhancement to the DynamoDBValueSensor, enabling it to wait for the presence of any value from a specified list of attribute values in a DynamoDB item.

Changes Proposed

  • Extend the DynamoDBValueSensor to accept a list of attribute values.
  • Update the documentation to reflect this new feature and provide examples.
  • Include tests to ensure the new functionality works as expected.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@vincbeck vincbeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Unless there is a valid reason, you can put your PR "in review"

@flolas
flolas marked this pull request as ready for review November 25, 2023 02:43
@flolas

flolas commented Nov 25, 2023

Copy link
Copy Markdown
Contributor Author

LGTM. Unless there is a valid reason, you can put your PR "in review"

Done. also, tests are ok and commits have been squashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants