Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions airflow/providers/postgres/operators/postgres.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from __future__ import annotations

import warnings
from typing import Mapping, Sequence
from typing import Mapping

from airflow.exceptions import AirflowProviderDeprecationWarning
from airflow.providers.common.sql.operators.sql import SQLExecuteQueryOperator
Expand Down Expand Up @@ -46,9 +46,7 @@ class PostgresOperator(SQLExecuteQueryOperator):
Deprecated - use `hook_params={'options': '-c <connection_options>'}` instead.
"""

template_fields: Sequence[str] = ("sql",)
template_fields_renderers = {"sql": "postgresql"}
template_ext: Sequence[str] = (".sql",)
template_fields_renderers = {**SQLExecuteQueryOperator.template_fields_renderers, "sql": "postgresql"}
ui_color = "#ededed"

def __init__(
Expand Down
16 changes: 16 additions & 0 deletions tests/providers/postgres/operators/test_postgres.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,3 +190,19 @@ def test_postgres_operator_openlineage_explicit_schema(self):
assert lineage_on_complete.outputs[0].namespace == "postgres://postgres:5432"
assert lineage_on_complete.outputs[0].name == "airflow.public.test_airflow"
assert "schema" in lineage_on_complete.outputs[0].facets


def test_parameters_are_templatized(create_task_instance_of_operator):
"""Test that PostgreSQL operator could template the same fields as SQLExecuteQueryOperator"""
ti = create_task_instance_of_operator(
PostgresOperator,
postgres_conn_id="{{ param.conn_id }}",
sql="SELECT * FROM {{ param.table }} WHERE spam = %(spam)s;",
parameters={"spam": "{{ param.bar }}"},
dag_id="test-postgres-op-parameters-are-templatized",
task_id="test-task",
)
task: PostgresOperator = ti.render_templates({"param": {"conn_id": "pg", "table": "foo", "bar": "egg"}})
assert task.conn_id == "pg"
assert task.sql == "SELECT * FROM foo WHERE spam = %(spam)s;"
assert task.parameters == {"spam": "egg"}