Use a AwsBaseWaiterTrigger-based trigger in EmrAddStepsOperator deferred mode - #34216
Merged
potiuk merged 5 commits intoSep 11, 2023
Merged
Conversation
* to be used by the EmrAddStepsOperator in deferred mode
boring-cyborg
Bot
added
area:providers
provider:amazon
yermalov-here
changed the title
yermalov-here
changed the title
yermalov-here
marked this pull request as draft
September 8, 2023 15:10
yermalov-here
marked this pull request as ready for review
September 8, 2023 15:48
yermalov-here
changed the title
Contributor
Author
|
Please note that i'd be glad to update this PR, especially based on the answers to the questions mentioned in the description. |
Contributor
Contributor
|
Why creating a new trigger and not modifying |
Taragolis
reviewed
Sep 8, 2023
| from airflow.providers.amazon.aws.hooks.base_aws import AwsGenericHook | ||
|
|
||
|
|
||
| @deprecated(reason="use EmrStepsTrigger instead") |
Contributor
There was a problem hiding this comment.
I don't think we should deprecate it especially if it never work properly. Just need to fix it so you could move your implementation here
Contributor
Author
|
Replaced the implementation of the EmrAddStepsTrigger |
Taragolis
approved these changes
Sep 10, 2023
potiuk
approved these changes
Sep 11, 2023
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reimplements EmrAddStepsTrigger based on the AwsBaseWaiterTrigger to be used in the EmrAddStepsOperator in deferred mode.
related: #34183
closes: #34177
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.