fix(providers-google): gcp_conn_id parameter ignored in GKEStartPodOperator hook property - #34194
Merged
Merged
Conversation
potiuk
approved these changes
Sep 11, 2023
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced in "Add deferrable mode to GKEStartPodOperator" (#29266).
gcp_conn_idis not passed as parameter during theGKEPodHookinstanciation inGKEStartPodOperator.hook. This results in thegcp_conn_idbeing ignored and replaced by the default valuegoogle_cloud_defaultas can be seen in the following logs.[2023-09-07, 19:14:32 UTC] {base.py:73} INFO - Using connection ID 'google_cloud_airflow_gke' for task execution. [2023-09-07, 19:14:32 UTC] {kubernetes_engine.py:288} INFO - Fetching cluster (project_id=<redacted>, location=<redacted>, cluster_name=<redacted>) [2023-09-07, 19:14:32 UTC] {pod.py:852} INFO - Building pod gke-pod-12asd34v with labels: {'dag_id': '<redacted>', 'task_id': '<redacted>', 'run_id': 'manual__2023-09-07T190347.0421980000-2fafa4fb6', 'kubernetes_pod_operator': 'True', 'try_number': '3'} [2023-09-07, 19:14:32 UTC] {pod.py:907} ERROR - The conn_id `google_cloud_default` isn't definedThis PR also adds unit tests to validate usage of
gcp_conn_id^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.