Skip to content

Upgrade azure-mgmt-datafactory in microsift azure provider - #34040

Merged
eladkal merged 4 commits into
apache:mainfrom
astronomer:unpin-az-datafactory
Oct 6, 2023
Merged

Upgrade azure-mgmt-datafactory in microsift azure provider#34040
eladkal merged 4 commits into
apache:mainfrom
astronomer:unpin-az-datafactory

Conversation

@pankajastro

@pankajastro pankajastro commented Sep 2, 2023

Copy link
Copy Markdown
Member

Related to: #30199


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@eladkal

eladkal commented Sep 4, 2023

Copy link
Copy Markdown
Contributor

You can use #29764 as reference to address some of the issues

@pankajastro
pankajastro force-pushed the unpin-az-datafactory branch 2 times, most recently from cbe5cc8 to 1fa43a6 Compare September 13, 2023 14:40
@pankajastro

Copy link
Copy Markdown
Member Author

Now CI is green but looks like old typing was not correct in the older version also resource_group_name and
factory_name were positional args. But this would be a breaking change since the current hook interface considers these params as optional params. https://github.com/Azure/azure-sdk-for-python/blob/azure-mgmt-datafactory_1.1.0/sdk/datafactory/azure-mgmt-datafactory/azure/mgmt/datafactory/operations/_data_flows_operations.py#L48

@eladkal

eladkal commented Sep 28, 2023

Copy link
Copy Markdown
Contributor

@pankajastro We can do a breaking release if needed

@pankajastro
pankajastro force-pushed the unpin-az-datafactory branch from c510b4b to d7c1a9e Compare October 3, 2023 14:09
@pankajastro
pankajastro requested a review from eladkal October 3, 2023 17:50
@pankajastro
pankajastro marked this pull request as ready for review October 3, 2023 17:50
@eladkal
eladkal merged commit 1fc2867 into apache:main Oct 6, 2023
@pankajastro
pankajastro deleted the unpin-az-datafactory branch October 6, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants