Allowing short package names in build-docs breeze command - #34004
Merged
Conversation
amoghrajesh
requested review from
ashb,
jedcunningham and
potiuk
as code owners
September 1, 2023 11:30
Contributor
Author
Contributor
|
We need also to update README_RELEASE_PROVIDER_PACKAGES.md airflow/dev/README_RELEASE_PROVIDER_PACKAGES.md Lines 362 to 366 in ffc9854 |
potiuk
reviewed
Sep 1, 2023
amoghrajesh
changed the title
Contributor
Author
|
@eladkal @potiuk with the current changes, we have not retired the older It takes combination of args + option from package-filter together! |
potiuk
force-pushed
the
shortenPackageFilter
branch
from
September 3, 2023 10:02
1ae2e03 to
a0903ec
Compare
potiuk
reviewed
Sep 3, 2023
Member
|
One small thing also to add: Line 92 in 0d93cc5 --package-filter.
There is also a follow-up after that one, but it should be a separate PR. We should adapt the current CI/selective checks to use the list of short package ids rather than |
uranusjr
reviewed
Sep 4, 2023
Contributor
Author
|
@potiuk Made the changes. Can you take a look? |
eladkal
reviewed
Sep 4, 2023
Member
|
Random error. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing short_version flag so that the users who build docs can now provide a short hand name instead of the whole name while building the docs for specific packages.
Some examples:
Selecting two packages - cncf kubernetes and airbyte using short hand
closes: #33876
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.