Skip to content

Sort data before groupby in TIS duration calculation #33535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uranusjr merged 3 commits into from
Aug 24, 2023
Merged

Sort data before groupby in TIS duration calculation #33535

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a118395
Sort data before groupby in tis duration
Taragolis Aug 19, 2023
c42a112
Avoid E731
Taragolis Aug 20, 2023
69c3193
Use nested function for resolve grouping/sorting key
Taragolis Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions airflow/www/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3236,10 +3236,12 @@ def duration(self, dag_id: str, session: Session = NEW_SESSION):
if failed_task_instance.duration:
fails_totals[dict_key] += failed_task_instance.duration

# we must group any mapped TIs by dag_id, task_id, run_id
# We must group any mapped TIs by dag_id, task_id, run_id
def grouping_key(ti: TaskInstance):
return ti.dag_id, ti.task_id, ti.run_id

mapped_tis = set()
tis_grouped = itertools.groupby(task_instances, lambda x: (x.dag_id, x.task_id, x.run_id))
for _, group in tis_grouped:
for _, group in itertools.groupby(sorted(task_instances, key=grouping_key), key=grouping_key):
tis = list(group)
duration = sum(x.duration for x in tis if x.duration)
if duration:
Expand Down