Simplify 'X for X in Y' to 'Y' where applicable - #33453
Merged
Merged
Conversation
eumiro
requested review from
XD-DENG,
ashb,
bbovenzi,
eladkal,
hussein-awala,
jedcunningham,
kaxil,
o-nikolas,
pierrejeambrun,
potiuk and
ryanahamilton
as code owners
August 16, 2023 17:33
boring-cyborg
Bot
added
area:core-operators
area:dev-tools
area:lineage
area:logging
area:production-image
hussein-awala
approved these changes
Aug 16, 2023
vincbeck
approved these changes
Aug 16, 2023
uranusjr
reviewed
Aug 17, 2023
uranusjr
reviewed
Aug 17, 2023
uranusjr
reviewed
Aug 18, 2023
Member
There was a problem hiding this comment.
Suggested change
| assert not list(files) | |
| with pytest.raises(StopIteration): | |
| next(files) |
Alternative approach. Shouldn’t be too much difference in practice (especially in a test).
Contributor
Author
There was a problem hiding this comment.
This is really elegant. Anyway, since the previous block already expects a StopIteration, we do not have to repeat it here. I'll remove it altogether.
uranusjr
approved these changes
Aug 18, 2023
potiuk
approved these changes
Aug 20, 2023
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
(cherry picked from commit 7700fb1)
97 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify loops without condition
X for X in Yto bareY, or convert it tolist()orset()oriter()if needed.