Add sql_hook_params parameter to SqlToS3Operator - #33425
Merged
Merged
Conversation
alexbegg
force-pushed
the
SqlToS3-hook_params
branch
2 times, most recently
from
August 16, 2023 00:34
e904703 to
9903043
Compare
alexbegg
marked this pull request as draft
August 16, 2023 00:40
alexbegg
force-pushed
the
SqlToS3-hook_params
branch
from
August 16, 2023 01:16
9903043 to
0ab1663
Compare
alexbegg
marked this pull request as ready for review
August 16, 2023 01:16
uranusjr
approved these changes
Aug 16, 2023
Contributor
Author
|
FYI, I added a test to |
Member
|
Because you changed how the BaseHook is accessed and it breaks the mock. |
alexbegg
force-pushed
the
SqlToS3-hook_params
branch
from
August 16, 2023 05:56
0ab1663 to
c356333
Compare
alexbegg
force-pushed
the
SqlToS3-hook_params
branch
from
August 16, 2023 05:59
c356333 to
dc943c0
Compare
Adding `sql_hook_params` parameter to `SqlToS3Operator`. This will allow you to pass extra config params to the underlying SQL hook. This uses the same "sql_hook_params" parameter name as already used in `SqlToSlackOperator`.
alexbegg
force-pushed
the
SqlToS3-hook_params
branch
from
August 16, 2023 06:06
dc943c0 to
f3f71ff
Compare
Contributor
Author
|
I have now split the |
vincbeck
approved these changes
Aug 16, 2023
sql_hook_params parameter to SqlToS3Operator
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
Adding `sql_hook_params` parameter to `SqlToS3Operator`. This will allow you to pass extra config params to the underlying SQL hook.
63 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
sql_hook_paramsparameter toSqlToS3Operator. This will allow you to pass extra config params to the underlying SQL hook.This uses the same parameter name, "sql_hook_params", as already used in
SqlToSlackOperator.(This is related to #33427 which adds
sql_hook_paramsto the opposite transfer,S3ToSqlOperator, however that one needed a different approach by usingBaseHook.get_hookinstead ofConnection.get_hook)^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.