Skip to content

Some minor updates to the Airflow release Doc - #31024

Merged
jedcunningham merged 4 commits into
apache:mainfrom
astronomer:update-releasedoc
May 16, 2023
Merged

Some minor updates to the Airflow release Doc#31024
jedcunningham merged 4 commits into
apache:mainfrom
astronomer:update-releasedoc

Conversation

@ephraimbuddy

@ephraimbuddy ephraimbuddy commented May 2, 2023

Copy link
Copy Markdown
Contributor

Update to what I noticed during the 2.6.0 release

@ephraimbuddy
ephraimbuddy force-pushed the update-releasedoc branch 2 times, most recently from fb5fb14 to 29ad965 Compare May 2, 2023 18:15
check=True,
)
console_print("Files pushed to svn")
os.chdir(repo_root)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you should need this change. remove_old_releases moves to a different dir anyways, then moves back to the repo root.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At that point, we are in the "versions" directory. We can't change to "asf-dist..." right there because it cannot be found.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Can we the change remove_old_releases to do this "reset to repo root" instead?

Comment thread dev/breeze/src/airflow_breeze/commands/release_command.py Outdated
check=True,
)
console_print("Files pushed to svn")
os.chdir(repo_root)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Can we the change remove_old_releases to do this "reset to repo root" instead?

Comment thread dev/breeze/src/airflow_breeze/commands/release_candidate_command.py
@jedcunningham
jedcunningham merged commit b633111 into apache:main May 16, 2023
@jedcunningham
jedcunningham deleted the update-releasedoc branch May 16, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants