Allow xcom sidecar container image to be configurable - #26766
Merged
Conversation
boring-cyborg
Bot
added
provider:cncf-kubernetes
bdsoha
changed the title
This should be valid until the code is actually removed from the codebase.
bdsoha
changed the title
This should be valid until the code is actually removed from the codebase.
bdsoha
force-pushed
the
feature/sidecar_container
branch
from
September 29, 2022 23:40
a82cb8d to
cf0c9a6
Compare
dstandish
requested changes
Sep 30, 2022
bdsoha
marked this pull request as draft
September 30, 2022 08:04
bdsoha
marked this pull request as ready for review
September 30, 2022 08:51
bdsoha
requested review from
XD-DENG and
dstandish
and removed request for
XD-DENG,
dstandish and
jedcunningham
November 2, 2022 19:47
potiuk
approved these changes
Nov 6, 2022
potiuk
left a comment
potiuk
left a comment
Member
There was a problem hiding this comment.
LGTM. But we need to wait for @dstandish's re-review.
Contributor
Author
|
@dstandish @XD-DENG Any we can get this merged? Thanks in advance. |
Contributor
|
ok lemme look |
dstandish
reviewed
Nov 8, 2022
dstandish
left a comment
dstandish
left a comment
Contributor
There was a problem hiding this comment.
mainly one docs reqeust
Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
dstandish
approved these changes
Nov 9, 2022
dstandish
added a commit
to astronomer/airflow
that referenced
this pull request
May 12, 2023
We probably should not be configuring xcom settings from the hook in this way but for better or worse we've done it, first in apache#26766 and again in apache#28125. The problem is that other operators derived from KPO, e.g. GKEStartPodOperator, may use a different hook that doesn't have this xcom-specific methods. So KPO needs to tolerate that.
|
Hello, is this PR in any version released? I can't find the changes in the current version 2.6.3 or in the main-branch. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10605.
Adding a configurable image value to the
KubernetesHookwhich is used byPodDefaults.SIDECAR_CONTAINER.imagewill allow both:alpine:latestimage with a specific tag.