Add indexes for CASCADE deletes for task_instance

[dstandish]

When we add foreign keys with ON DELETE CASCADE, and we delete rows in the foreign table, the database needs to join back to the referencing table. If there's no suitable index, then it can be slow to perform the deletes.

cc @wolfier

closes #24484

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[calfzhou]

Upgrading airflow 2.3.2 to 2.3.3, db upgrade failed:

Running upgrade 3c94c427fdf6 -> f5fcbda3e651, Add indexes for CASCADE deletes on task_instance
...
MySQLdb.OperationalError: (1067, "Invalid default value for 'end_date'")

(MySQL 8.0)

I checked that my task_reschedule table is empty.

[potiuk]

@calfzhou - you might have your mysql configured with "NO ZERO DATE" and "STRICT MODE".
https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sqlmode_no_zero_date.

Can you please confirm that?

If so, you might want to disable it - https://stackoverflow.com/questions/9192027/invalid-default-value-for-create-date-timestamp-field.

[calfzhou]

@calfzhou - you might have your mysql configured with "NO ZERO DATE" and "STRICT MODE". https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sqlmode_no_zero_date.

Can you please confirm that?

If so, you might want to disable it - https://stackoverflow.com/questions/9192027/invalid-default-value-for-create-date-timestamp-field.

Thanks @potiuk , that works! I removed NO_ZERO_DATE from sql mode.

[potiuk]

Cool!

One question @calfzhou - maybe you would like to add a note about it as PR to https://airflow.apache.org/docs/apache-airflow/stable/howto/set-up-database.html?highlight=database+setup#setting-up-a-mysql-database ? We already have a few watch-outs there and adding this one might be useful for others.

It's super easy - just click "Suggest a change on this page" and you will get a PR where you will be able to directly edit the page sources and you could just use similar approach as other warnings there ?

[calfzhou]

PR posted #24983