[AIRFLOW-1247] Fix ignore all dependencies argument ignored

[ghost]

Cause: Comma missing so the store_true argument goes to help string.
Fix: Add missing comma

Dear Airflow maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

• My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-XXX

Description

• Here are some details about my PR, including screenshots of any UI changes:

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

[mention-bot]

@mremes, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mistercrunch, @bolkedebruin and @aoen to be potential reviewers.

[aoen]

LGTM, thanks!

[codecov-io]

Codecov Report

Merging #2327 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2327      +/-   ##
==========================================
+ Coverage      71%   71.08%   +0.07%     
==========================================
  Files         150      150              
  Lines       11740    11740              
==========================================
+ Hits         8336     8345       +9     
+ Misses       3404     3395       -9

Impacted Files	Coverage Δ
airflow/bin/cli.py	53.45% <ø> (+1.41%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e52070...256336f. Read the comment docs.

[bolkedebruin]

Can you please add tests and update the commit message?

[bolkedebruin]

@mremes please don't forget the tests: it is the reason why it was not caught in the first place.

[ghost]

@bolkedebruin added tests for upstream and depends_on_past dependencies not met. Run the scenario locally as I don't have the dev environment setup for running the tests yet... Will probably need to as there's more to contribute

[bolkedebruin]

can you make the tests pass?

[ghost]

@bolkedebruin It passes all well

[saguziel]

better to change this to action="store_true", then this issue would have been avoided. Bonus points for fixing the othoer cases.

[ghost]

@saguziel probably a refactoring PR would be the right place to do that.

[aoen]

@mremes Ready to LGTM/merge when tests are passing: https://travis-ci.org/apache/incubator-airflow/builds/237275876?utm_source=github_status&utm_medium=notification

[ashb]

@mremes One of the causes of the test failure is a missing license in dags/test_cli_triggered_dags.py -- could you add it please?

[criccomini]

Checking on status. If you want this in 1.9.0, it needs to get merged shortly.

[ghost]

@criccomini done, fixed tests by adding the license to the head of the test file.

The code change is the same as in the #2441, except this adds the tests for the functionality.

[criccomini]

Merging!