Fix mypy typing issues for airflow.executors - #20017
Merged
Merged
Conversation
jedcunningham
requested review from
XD-DENG,
ashb,
dimberman and
kaxil
as code owners
December 3, 2021 15:40
boring-cyborg
Bot
added
provider:cncf-kubernetes
potiuk
approved these changes
Dec 3, 2021
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
Bot
added
the
full tests needed
jedcunningham
force-pushed
the
fix_mypy_executors
branch
from
December 3, 2021 17:49
1ccad5d to
f4c0177
Compare
Member
|
Does this need another relbase to run CI correctly? |
uranusjr
approved these changes
Dec 3, 2021
jedcunningham
force-pushed
the
fix_mypy_executors
branch
from
December 3, 2021 19:25
f4c0177 to
9ad9e6d
Compare
kaxil
approved these changes
Dec 3, 2021
kaxil
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes all the issue in
airflow.executorsexcept for 2 inairflow.executors.celery_executor.py, which will be fixed as part of #20000.Related to #19891.