Skip to content

Show serialization exceptions in DAG parsing log #17277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jedcunningham merged 1 commit into from
Jul 28, 2021
Merged

Show serialization exceptions in DAG parsing log #17277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airflow/models/dagbag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,7 @@ def _serialize_dag_capturing_errors(dag, session):
except OperationalError:
raise
except Exception:
self.log.exception("Failed to write serialized DAG: %s", dag.full_filepath)
return [(dag.fileloc, traceback.format_exc(limit=-self.dagbag_import_error_traceback_depth))]

# Retry 'DAG.bulk_write_to_db' & 'SerializedDagModel.bulk_sync_to_db' in case
Expand Down
4 changes: 3 additions & 1 deletion tests/models/test_dagbag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,9 @@ def test_serialized_dag_errors_are_import_errors(self, mock_serialize):
)
assert dagbag.import_errors == {}

dagbag.sync_to_db(session=session)
with self.assertLogs(level="ERROR") as cm:
dagbag.sync_to_db(session=session)
self.assertIn("SerializationError", "\n".join(cm.output))

assert path in dagbag.import_errors
err = dagbag.import_errors[path]
Expand Down