Adds more explanatory message when SecretsMasker is not configured - #17101
Merged
potiuk merged 1 commit intoJul 20, 2021
Merged
Conversation
The secrets masker added in 2.1.0 introduced requirement that at least one SecretsMasker needs to be configured per task. However this introduced problems for several users who migrated from Airflow 1.10 and had their custom logging configuration done without first copying the base airflow configuration. The message about missing SecretsMasker was pretty cryptic for the users. This PR changes the message to be much more descriptive and pointing the user to the right place in documentation explaining how advanced logging configuration should be done.
uranusjr
approved these changes
Jul 20, 2021
github-actions
Bot
added
the
full tests needed
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
jhtimmins
pushed a commit
that referenced
this pull request
Aug 9, 2021
…17101) The secrets masker added in 2.1.0 introduced requirement that at least one SecretsMasker needs to be configured per task. However this introduced problems for several users who migrated from Airflow 1.10 and had their custom logging configuration done without first copying the base airflow configuration. The message about missing SecretsMasker was pretty cryptic for the users. This PR changes the message to be much more descriptive and pointing the user to the right place in documentation explaining how advanced logging configuration should be done. (cherry picked from commit 3a2e162)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 13, 2021
…17101) The secrets masker added in 2.1.0 introduced requirement that at least one SecretsMasker needs to be configured per task. However this introduced problems for several users who migrated from Airflow 1.10 and had their custom logging configuration done without first copying the base airflow configuration. The message about missing SecretsMasker was pretty cryptic for the users. This PR changes the message to be much more descriptive and pointing the user to the right place in documentation explaining how advanced logging configuration should be done. (cherry picked from commit 3a2e162)
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
…17101) The secrets masker added in 2.1.0 introduced requirement that at least one SecretsMasker needs to be configured per task. However this introduced problems for several users who migrated from Airflow 1.10 and had their custom logging configuration done without first copying the base airflow configuration. The message about missing SecretsMasker was pretty cryptic for the users. This PR changes the message to be much more descriptive and pointing the user to the right place in documentation explaining how advanced logging configuration should be done. (cherry picked from commit 3a2e162)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
…17101) The secrets masker added in 2.1.0 introduced requirement that at least one SecretsMasker needs to be configured per task. However this introduced problems for several users who migrated from Airflow 1.10 and had their custom logging configuration done without first copying the base airflow configuration. The message about missing SecretsMasker was pretty cryptic for the users. This PR changes the message to be much more descriptive and pointing the user to the right place in documentation explaining how advanced logging configuration should be done. (cherry picked from commit 3a2e162)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The secrets masker added in 2.1.0 introduced requirement that
at least one SecretsMasker needs to be configured per task.
However this introduced problems for several users who migrated
from Airflow 1.10 and had their custom logging configuration
done without first copying the base airflow configuration.
The message about missing SecretsMasker was pretty cryptic for the
users. This PR changes the message to be much more descriptive
and pointing the user to the right place in documentation
explaining how advanced logging configuration should be done.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.