Skip to content

New generic tableau operator: TableauOperator - #16915

Merged
potiuk merged 44 commits into
apache:mainfrom
mariotaddeucci:main
Aug 9, 2021
Merged

New generic tableau operator: TableauOperator #16915
potiuk merged 44 commits into
apache:mainfrom
mariotaddeucci:main

Conversation

@mariotaddeucci

Copy link
Copy Markdown
Contributor

Added an generic tableau operator to execute multiple methods on python client.

Added generic tableau operator to execute multiple methods on python client
@boring-cyborg

boring-cyborg Bot commented Jul 9, 2021

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments in the code.
Note that also requires tests for TableauOperator

Comment thread airflow/providers/tableau/operators/tableau.py Outdated
Comment thread airflow/providers/tableau/operators/tableau_refresh_workbook.py Outdated
- Fixed documentation comments on TableauOperator execute
- Added generic find by column
- Deprecated TableauRefreshWorkbookOperator
@mariotaddeucci

Copy link
Copy Markdown
Contributor Author

@eladkal I adapt the tests from TableauRefreshWorkbookOperator and the tests from PR #16937

@mariotaddeucci
mariotaddeucci requested a review from eladkal July 14, 2021 00:54
Comment thread airflow/providers/tableau/operators/tableau_refresh_workbook.py Outdated
Comment thread airflow/providers/tableau/operators/tableau.py Outdated
Comment thread airflow/providers/tableau/provider.yaml
Comment thread airflow/providers/tableau/operators/tableau.py Outdated
@mariotaddeucci
mariotaddeucci requested a review from eladkal July 15, 2021 04:35
@eladkal

eladkal commented Jul 15, 2021

Copy link
Copy Markdown
Contributor

@mariotaddeucci we just merged #16916 can you please rebase and fix conflicts?

@mariotaddeucci

mariotaddeucci commented Aug 3, 2021

Copy link
Copy Markdown
Contributor Author

@eladkal @potiuk the unit tests have run successfully now ✅

@potiuk

potiuk commented Aug 4, 2021

Copy link
Copy Markdown
Member

Static checks and docs are still failing I am afraid.

Comment thread docs/apache-airflow-providers-tableau/operators.rst Outdated
@mariotaddeucci

mariotaddeucci commented Aug 8, 2021

Copy link
Copy Markdown
Contributor Author

@eladkal the last commit haven't passed on on CI Build / Build and test provider packages wheel because pypsrc on Microsoft provider and wasn't caused by this PR. Is there anything else that this PR needs?

@potiuk

potiuk commented Aug 8, 2021

Copy link
Copy Markdown
Member

New dependency was added by new provider and you need to rebase to get it working I am afraid :)

@eladkal eladkal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (left one comment on but it's not that important)

Comment thread docs/apache-airflow-providers-tableau/operators.rst
@github-actions

github-actions Bot commented Aug 8, 2021

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Aug 8, 2021
@potiuk
potiuk merged commit 5df99d6 into apache:main Aug 9, 2021
@boring-cyborg

boring-cyborg Bot commented Aug 9, 2021

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

@potiuk

potiuk commented Aug 9, 2021

Copy link
Copy Markdown
Member

Woohoo!

@mariotaddeucci

Copy link
Copy Markdown
Contributor Author

Thanks all for supporting me on this PR @eladkal @potiuk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants