Refactoring utils to be more sane - #1098
Conversation
| dag.sla_miss_callback(dag, task_list, blocking_task_list, slas, blocking_tis) | ||
| notification_sent = True | ||
| from airflow import ascii | ||
| from airflow.utils import asciiart |
There was a problem hiding this comment.
Nit: Scope creep, but can you pull this to the top of the file?
| import signal | ||
|
|
||
|
|
||
| class AirflowTaskTimeout(Exception): |
There was a problem hiding this comment.
I think you meant to remove this from here
There was a problem hiding this comment.
I was torn on this one since it is used right below in the timeout class. But I will move it to exceptions for consistency.
There was a problem hiding this comment.
I think it is in both places ATM.
|
Thanks for this change, this is great! Looks good, mostly nits. |
|
That was epic. The build is now passing, let me know if people have more comments! |
|
LGTM, thanks for addressing everything! |
|
It's just moving 1k lines around. What could go wrong?! |
|
Here's hoping the test coverage is good ^^. |
|
@mistercrunch The only potential issue that I have seen is the It should be a quick fix though. |
|
@mistercrunch. Bump. |
|
Seems like |
|
Superseded by #1219 |
|
|
4 participants
A refactor of the
airflow.utilsfrom a file into a folder with topics. As we scale out the Airflow code base, this will help us follow good practices of keeping small modules, and will make finding code easier.The goal of this PR is to establish foundations to that effect, following the examples set by projects like Django and IPython.
This is more of a starting point, and I welcome comments on how to make this better. I apologize for the sheer size fo the PR, the surgery was extensive.
Note that this will include some backwards incompatible changes in
utils. Sinceutilsis mostly used by people extending Airflow, I believe this is still ok, and will help the community grow by making the code base better organized and easier to contribute to.@mistercrunch