Airflow SalesforceHook empty security token

[parvezmkhan]

Apache Airflow version

2.2.2

What happened

When creating salesforce hook like below get
sf = SalesforceHook(salesforce_conn_id="test_sf")

Get below TypeError
You must provide login information or an instance and token

This is test salesforce domain.
User name and password are set correctly in Airflow connection but security token is not filled.
I expect the connection to setup without error

What you think should happen instead

Changing

airflow/airflow/providers/salesforce/hooks/salesforce.py

Line 144 in 1d53bec

security_token=extras.get('extra__salesforce__security_token') or None,

to below works, i.e. connection is established
security_token=extras["extra__salesforce__security_token"] or '',

How to reproduce

Setup salesforce connection in airflow with

• user name, password and no security token
• domain : test
• API version : 54.0

Operating System

macOS 11.2.3

Versions of Apache Airflow Providers

apache-airflow-providers-salesforce 3.3.0
simple-salesforce 1.11.4

Deployment

Virtualenv installation

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[boring-cyborg]

Thanks for opening your first issue here! Be sure to follow the issue template!

[eladkal]

You are using apache-airflow-providers-salesforce 3.3.0 which is out of date.
Check the changelog version 3.4.0 included
Do not require all extras for SalesforceHook (#19530)

[parvezmkhan]

@eladkal
Thanks a lot for looking into this.

I upgraded to 3.4.4 as shown below
`
pip install --upgrade apache-airflow-providers-salesforce==3.4.4

pip show apache-airflow-providers-salesforce
Name: apache-airflow-providers-salesforce
Version: 3.4.4
`

After running, still get same error
sf = SalesforceHook(salesforce_conn_id="test_sf") ... TypeError: You must provide login information or an instance and token
Am I doing something wrong?

Thanks!

[eladkal]

Please follow
https://airflow.apache.org/docs/apache-airflow-providers-salesforce/stable/connections/salesforce.html

There are different types of authentication to salesforce. Make sure you are following the insteuctions