GoogleCloudStorageToBigQueryOperator reads string as a list in parameter source_objects

[stavhaco]

Apache Airflow version:1.10.12
Environment: google cloud composer

What happened:
When using GoogleCloudStorageToBigQueryOperator and providing string as parameter source_objects, the process is iterating on a the string as a valid list.
For example -
cloud_storage_to_bigquery = GoogleCloudStorageToBigQueryOperator( bucket = 'bucket', source_objects = 'abc', )
Will result in looking into the sources: bucket/a, bucket/b, bucket/c.

What you expected to happen:
Throw an error on type (string instead of list).

[boring-cyborg]

Thanks for opening your first issue here! Be sure to follow the issue template!

[eladkal]

GoogleCloudStorageToBigQueryOperator is deprecated. Please use GCSToBigQueryOperator from providers.
Note that source_objects expect list not str. You should set source_objects = ['abc']

[stavhaco]

@eladkal seems like the behaviour is the same in GCSToBigQueryOperator.
I get that the parameter should be set as source_objects = ['abc'] but shouldn't I expect type error when setting it to source_objects = 'abc'? instead of iterating on the chars of the string and looking for different paths based on it?

[eladkal]

PRs are welcome :)

[stavhaco]

@eladkal Alright. Can this be assigned to me?

[eladkal]

You can just open a PR
BTW probably a better solution would be to allow str or List[str] rather than raise error.