Fix issues with LogEntryTest - #4035
Merged
Merged
Conversation
ctubbsii
commented
Dec 7, 2023
ctubbsii
commented
Member
- Make constants private
- Use SimpleImmutableMap instead of anonymous inner class
- Include getFilePath method in testEquals
- Test all methods using the constructor
- Test all methods using fromMetaWalEntry
- Remove testing of invalid "foo" path that wasn't actually read
* Make constants private * Use SimpleImmutableMap instead of anonymous inner class * Include getFilePath method in testEquals * Test all methods using the constructor * Test all methods using fromMetaWalEntry * Remove testing of invalid "foo" path that wasn't actually read
Member
Author
|
Thanks to @keith-turner for helping me make sense of the existing test. I'm still not sure what the original test was trying to cover overall... it just seemed to be testing random things. I rewrote it so it made a bit more sense. This should help with #3997 |
Contributor
|
Thank you for fixing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.