Add Support for RTL text in most UI elements (#759)#760
Merged
Conversation
damageboy
force-pushed
the
dmg/more_bidi
branch
2 times, most recently
from
6b5e36d to
61fdc2b
Compare
devceline
reviewed
Jun 26, 2025
devceline
left a comment
devceline
left a comment
Contributor
There was a problem hiding this comment.
Does this have any noticeable impact on performance? I considered doing this when I added the PR for lyrics but I thought the trade off might not be worth it.
Contributor
Author
|
Not on my macbook pro m3, the code I lifted off of a previous PR is at least minimalistic in its approach by doing as little as possible if bidi strings are not at play... |
devceline
reviewed
Jun 28, 2025
devceline
left a comment
devceline
left a comment
Contributor
There was a problem hiding this comment.
Can we also re-use the same logic for lyrics
Contributor
Author
|
Sure, I'll re-use the sI've unified everything to go through one impl of Repushed @ f44cf86 |
- Search results - Playback Metadata/Rect - Main View - Playlist View
aome510
approved these changes
Jul 27, 2025
tojamrok
pushed a commit
to tojamrok/spotify-player
that referenced
this pull request
Sep 3, 2025
Resolves aome510#759 - Search results - Playback Metadata/Rect - Main View - Playlist View Before:  After: 
damageboy
added a commit
to damageboy/ytermusic
that referenced
this pull request
Feb 27, 2026
- closes ccgauche#136 - adopts the code from aome510/spotify-player#760 which achieved the - Apply Unicode Bidirectional Algorithm via unicode-bidi crate to reorder RTL text (Hebrew, Arabic) for correct terminal display. - Add calls to to_bidi_string() utility and applies it at all user-facing rendering points: music player title/playlist, search results, playlist chooser, and playlist inspector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #759
Before:
After:
