Skip to content

fix(etw): recover after collector and guard loss - #969

Merged
antropos17 merged 2 commits into
masterfrom
codex/etw-dual-recovery-20261018
Oct 18, 2026
Merged

antropos17 merged 2 commits into
masterfrom
codex/etw-dual-recovery-20261018

Conversation

@antropos17

@antropos17 antropos17 commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Description

Losing both the diagnostic ETW collector and its primary guard left no surviving elevated owner that could recover the original session. Start an independent fallback before StartTrace and reserve the original per-capture GUID over mutually authenticated restricted pipes. It retains both original peer objects, waits for their exits, rechecks session identity and stops only by the matching handle. The broker validates fallback receipts and exits before main can permit explicit retry. Capture remains FAILED with unknown stage totals and an observation gap; production ETW remains disabled by default.

Add four fixed own-process crash cases (both ready loss orders, before arm and before start) to an eleven-capture packaged profile. Single guard loss also gains verified fallback cleanup. Broker loss continues to block retry without an authenticated terminal. No automatic capture/UAC retry, name-based stop, elevated kill, renderer IPC, workflow, lockfile or machine-setting change.

Type of change

  • Bug fix
  • Documentation update

Testing

  • Actual packaged Windows EXE: 11/11 PASS at 5a09b16ae2140ee91cb1772bc23aca7173f10603, including independent session presence/absence, original-peer exits, actual Sensors FAILED state, sync/pending-overlapped read witnesses and a subsequent normal capture. Portable evidence binds source/tree, receipts and package hashes. Final commit changes documentation/evidence only.
  • 81 native self-tests, including a failing-before/fixed-after fallback policy regression; 192 focused JavaScript tests; typecheck, task ESLint, native whitespace, normal-token synthetic transport and derived counts passed.
  • All 229 packaged main/shared JS/JSON files matched source; native DLL matched publish; all eleven profile audit scans excluded diagnostic admission. Final normal capture retained zero native/stage drops and 77 ring evictions.
  • All five required contexts and Windows native-fixtures passed on final head b45faaa84d7c870f45964df66605a15e03db6f66: CI, Windows fixtures. These hosted checks are separate from the live packaged evidence above.
  • Local Semgrep unavailable (ENOENT); no scanner success is claimed. Two-pass self-review completed; no independent human review is claimed.

Loss of all three elevated peers, protected durable recovery/service authority, protected installation, alternate credentials, actual sleep/wake, full I/O coverage and production/path admission remain unqualified. Faults cover both coordinated loss orders; instruction-level simultaneous termination is not claimed. Raw profiles/screenshots/receipts remain private under the existing manual seven-day review policy. The dirty primary checkout's seven tracked hashes and complete status were unchanged.

Checklist

  • Follows code style guidelines and keeps new files focused
  • No production console logging or new renderer IPC
  • Applicable local checks and actual packaged evidence recorded above
  • This code has been reviewed by a human

@antropos17
antropos17 merged commit fd8dc84 into master Oct 18, 2026
6 checks passed
@antropos17
antropos17 deleted the codex/etw-dual-recovery-20261018 branch October 18, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant