Skip to content

fix(review): refuse FIFO substitutions without blocking - #959

Merged
antropos17 merged 2 commits into
masterfrom
codex/refuse-result-review-fifo-20261016
Oct 16, 2026
Merged

antropos17 merged 2 commits into
masterfrom
codex/refuse-result-review-fifo-20261016

Conversation

@antropos17

@antropos17 antropos17 commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

A selected review file can be replaced by a POSIX FIFO after its initial file check. Read-only opening can then wait for a writer before the handle-type check runs, leaving review pending.

Use the supported nonblocking-open flag so the existing handle-type check promptly rejects the FIFO. Preserve the selected-file identity checks, ownership checks, bounded reads, fixed refusal and awaited handle close.

Validation: the isolated actual-FIFO regression reproduced the post-readiness timeout on the original reader in Ubuntu CI and passes unchanged on the repaired head. All five required CI contexts succeed on 30d39553; the Ubuntu suite reports 8,474 passes and 1,202 platform/capability exclusions. All 120 focused Windows consumer tests pass, with the POSIX control explicitly excluded; formatting and lint pass. Independent source and execution review covers 257 frozen inputs and the executed merge tree. No timeout wrapper, new IPC authority or launch acceptance is added.

@antropos17
antropos17 marked this pull request as ready for review October 16, 2026 17:43
@antropos17
antropos17 merged commit 437cda5 into master Oct 16, 2026
5 checks passed
@antropos17
antropos17 deleted the codex/refuse-result-review-fifo-20261016 branch October 16, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant