Repository navigation
fix(review): refuse FIFO substitutions without blocking - #959
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A selected review file can be replaced by a POSIX FIFO after its initial file check. Read-only opening can then wait for a writer before the handle-type check runs, leaving review pending.
Use the supported nonblocking-open flag so the existing handle-type check promptly rejects the FIFO. Preserve the selected-file identity checks, ownership checks, bounded reads, fixed refusal and awaited handle close.
Validation: the isolated actual-FIFO regression reproduced the post-readiness timeout on the original reader in Ubuntu CI and passes unchanged on the repaired head. All five required CI contexts succeed on
30d39553; the Ubuntu suite reports 8,474 passes and 1,202 platform/capability exclusions. All 120 focused Windows consumer tests pass, with the POSIX control explicitly excluded; formatting and lint pass. Independent source and execution review covers 257 frozen inputs and the executed merge tree. No timeout wrapper, new IPC authority or launch acceptance is added.