Repository navigation
fix(installer): preserve finite GUI failure diagnostics - #958
Merged
antropos17 merged 1 commit intoOct 16, 2026
Merged
Conversation
antropos17
deleted the
codex/preserve-gui-failure-diagnostics-20261016
branch
October 16, 2026 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Known GUI-helper failures currently become a generic publication refusal in the administrative journal receipt because their existing fixed codes and native operation identifiers are missing from the diagnostic allowlists.
Add the six existing GUI codes and three emitted operations to those literal lists. Exception traversal depth, precedence, exact type checks, same-cause Win32 pairing, first-failure retention and the closed receipt shape remain unchanged.
Validation: the real metadata-helper failure first reproduced the lost operation, then passed through the administrative receipt after this change. All 28 installer tests and five selected GUI controls pass; 37 unrelated GUI controls were excluded by the filter. The synthetic diagnostic matrix has 27 cases within one grouped test, including private-data exclusion, exact Int32 pairing and depth boundaries. A real malformed-manifest helper control also passes. Formatting and lint pass. Actual metadata failure has null Win32; numeric Win32 controls are explicitly synthetic. No native helper, authority seam, runtime activation or acceptance status changes.