Repository navigation
fix(installer): retain uncertain upgrade stage ownership - #957
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An upgrade that loses publication confirmation can leave its newly created stage reachable only through a local transaction variable. The administrative association still points to the old revision, so it no longer deliberately retains the new root, GUI bundle and creation journal after the transaction unwinds.
Retain the exact single issued stage in the association before stopping or moving either revision. Keep it through uncertain handoff, rollback or commit. Clear that slot only after confirmed removal of the same stage, or successful commit transferring that exact object into the current stage. Existing partial owners and unexpected references cause refusal without replacement or further recovery.
Validation: reproduced the original missing-reference failure; 28 installation transaction tests and two selected actual Windows GUI-stage composition tests pass. The transaction matrix contains 19 cases within one grouped test. The other 58 fixed-operation tests were excluded by the explicit filter. Formatting and lint pass; independent frozen-source review covers 292 inputs. Real GUI file handles, identities, bytes and typed moves are exercised; principal/protection, installed authority and journal metadata remain modeled. No GUI enrollment, ordinary runtime route, cleanup retry or launch acceptance is added.