Repository navigation
fix(session): share caller admission decision deadline - #956
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A connected silent caller could wait a fresh two seconds after its requested admission budget was spent. A competing admission could also wait on the active operation's gate and then close that operation. One monotonic budget now follows connection, frame reading, managed gate acquisition, authentication and final publication. A contender that never acquired ownership times out without consuming or closing the active admission.
Existing context freshness, original authority checks, impersonation reversion and owned cleanup remain intact. The budget governs admission eligibility; synchronous native observations and mandatory cleanup settlement can finish later. Original diagnostic signatures and checkpoint values remain compatible.
Validation: 393/393 fresh Windows controls across 14 suites, zero skips; seven production helpers rebuilt first; all 305 frozen inputs reconciled; targeted formatting/lint passed. Controls include real pipe/process/token behavior, late frames, expiry during token checks and reversion, active-owner preservation under contention, and post-authentication publication expiry. Labeled descriptor/installed-authority models remain separate from service, guest and end-to-end acceptance.