Repository navigation
fix: enforce the closed protected guest result contract - #946
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The administrative guest result checker accepted extra dictionary fields, coerced schema versions and arrays in identity fields, and returned the original object with remoting note properties. Those values could reach the settlement journal despite the documented result contract.
Require exactly eight case-sensitive dictionary keys, strict primitive types and the outstanding VM/nonce/executable binding. Validate dictionary size/keys through accessors that cannot be hidden by input keys, then journal and return a fresh canonical projection. Preserve one-use admission, fresh VM checks, nonzero exit codes and the disabled ordinary launch boundary.
Validation: first reproduced eight failing cases, then passed 79 local Windows tests across guest, VM and installation suites. Coverage includes malformed/extra/case-confused fields, shadowed dictionary members, duplicate results, metadata exclusion and a real Windows PowerShell background job with nested serialization. Formatting and diff checks passed. Required CI is checked on the final PR revision. No new Hyper-V or provider qualification is claimed; earlier hosted evidence retains source
5113e3b.