Repository navigation
fix(session): refuse parent-backed private VM disks - #937
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private VM registration previously inspected only the attached file, allowing an otherwise eligible differencing disk to refer to an unheld parent. Version-three registration now requires a standalone Microsoft fixed/dynamic VHD or VHDX through Windows information-only APIs with NO_PARENTS, while the original file and ancestors remain held. Loss of that observation permanently refuses the lease. Legacy read-only records retain compatibility.
The Windows qualification driver adds eleven actual disposable image controls before VM creation, including present/missing parents, corrupt/mismatched formats, disposed handles and retained writer denial. Source hashes and bounded failure progress remain in the existing receipt. No lifecycle permission or production acceptance is added.
Validation: both registration regressions failed before implementation and pass afterward; 167 local Windows checks passed (ten elevated creation cases explicitly skipped locally), the full PowerShell control bundle passed, and all seven native helpers built. All five required CI contexts passed on exact source 555dd89 in run 38651247952.
Windows11 run 38651247611 attempt 1 passed all eleven actual native disk-image cases, protected registration/upgrade inspection counts 1/1 and all 55 mutation denials. All 44 installed-owner inputs and 43 image-control inputs match the frozen source (raw CRLF differences retained). Windows setup and the fixed standard-user task passed. The overall run FAILED later in the unchanged Claude task with
scratch-limit; cancellation, stdio, owner lifetime and the guest installed-owner corpus were not reached. That failure is retained and is not a full-lab pass. VM Off/removal and all four finite file removals were confirmed, with no cleanup failure. Raw receipt: 545537 bytes, SHA256 17ab8b330fc9a3a645b4c4276ae251b35350d64df6118106c96c3e9629576da6.Both review passes were by current Codex. Overall acceptance stays 30/60; A1-A4 remain unreviewed and launch stays closed. Claude scratch observation remains a separate follow-up; its code and limits were unchanged by this PR.