Repository navigation
refactor(renderer): remove retired sparkline utility - #923
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The renderer sparkline utility is no longer used by the app. Its only importer was its own ten-test suite; active Statistics plotting uses
StatsChart/StatsPlotwithruntime/statistics-plot.tsandruntime/live-plot.ts. This removes the disconnected utility and exclusive test, then corrects the maintained renderer utility count from 17 to 16.Focused verification: four active Statistics/plot suites (30 tests), renderer and Observatory TypeScript checks,
counts:check(69/69), andgit diff --check. Independent GPT-6.1 Sol review found no P1/P2 issue on the exact commit. Hosted CI provides the five required broad checks. No native Electron or product acceptance is claimed.