Repository navigation
fix(renderer): preserve exception retry focus - #915
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a saved-exception status read fails, keyboard users can focus Retry status. Activating it previously removed that focused button as soon as the read became pending; focus fell to BODY and stayed there after recovery. Retry now remains focusable but guarded during verification. On success, owned focus moves to the enabled Mute false alarm/Re-enable alerts control, or to the existing path-limit status when that control must stay disabled. Failure retains Retry focus. Focus moved elsewhere and component unmount are respected.
Verification: actual component reproduction was RED before; focused Vitest 5 cases are GREEN 25/25 across the new regression and existing exceptions tests, including duplicate retry, failure, moved focus, unmount and over-limit path. Root typecheck, Svelte checks, scoped lint/format and independent GPT-6.1 Sol review pass; a reviewer-found over-limit focus gap was fixed and independently re-reviewed. Hosted CI supplies the required broad gates. Native Electron keyboard behavior remains unqualified.