Skip to content

fix(renderer): restore catalog focus after filtered edit - #914

Merged
antropos17 merged 2 commits into
masterfrom
codex/catalog-editor-focus-20261011
Oct 11, 2026
Merged

antropos17 merged 2 commits into
masterfrom
codex/catalog-editor-focus-20261011

Conversation

@antropos17

Copy link
Copy Markdown
Owner

Saving an edit while the Catalog is filtered to the agent's old name removes its Edit button from the DOM before the editor finishes its readback. Closing the dialog then leaves keyboard focus on BODY. EditorDialog now accepts an optional focus fallback; Catalog supplies its search field when the original opener is gone. Connected openers still receive focus, and focus already moved elsewhere is preserved.

Verification: actual Catalog component reproduction was RED for the filtered rename before and GREEN after. Four focused regression cases cover the missing opener, moved focus and Edit/Add cancellation; 30 existing Catalog/comfort cases also pass. After syncing to current master, all 34 focused cases pass under exact-lock Vitest 5. Root typecheck, Svelte checks, scoped lint/format and independent GPT-6.1 Sol review pass. Hosted CI will provide the required broad gates. Native dialog top-layer behavior is not claimed from jsdom.

@antropos17
antropos17 merged commit c658055 into master Oct 11, 2026
5 checks passed
@antropos17
antropos17 deleted the codex/catalog-editor-focus-20261011 branch October 11, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant