Repository navigation
fix(renderer): restore catalog focus after filtered edit - #914
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving an edit while the Catalog is filtered to the agent's old name removes its Edit button from the DOM before the editor finishes its readback. Closing the dialog then leaves keyboard focus on BODY. EditorDialog now accepts an optional focus fallback; Catalog supplies its search field when the original opener is gone. Connected openers still receive focus, and focus already moved elsewhere is preserved.
Verification: actual Catalog component reproduction was RED for the filtered rename before and GREEN after. Four focused regression cases cover the missing opener, moved focus and Edit/Add cancellation; 30 existing Catalog/comfort cases also pass. After syncing to current master, all 34 focused cases pass under exact-lock Vitest 5. Root typecheck, Svelte checks, scoped lint/format and independent GPT-6.1 Sol review pass. Hosted CI will provide the required broad gates. Native dialog top-layer behavior is not claimed from jsdom.