Skip to content

fix(renderer): restore action focus after pending - #913

Merged
antropos17 merged 1 commit into
masterfrom
codex/action-pending-focus-20261011
Oct 11, 2026
Merged

antropos17 merged 1 commit into
masterfrom
codex/action-pending-focus-20261011

Conversation

@antropos17

Copy link
Copy Markdown
Owner

The Settings notification Test action becomes natively disabled while its async operation runs. In Chromium, keyboard focus falls to BODY and stays there when the button re-enables, so a second Enter does nothing. Shared Action now restores the originally focused button after completion only when it remains connected and enabled and focus has not moved to another control. Native pending/disabled behavior and visual feedback remain unchanged.

Verification: actual Settings UI in Chromium reproduced BODY focus and a no-op second Enter before; after the change focus returns to Test and the second Enter runs the action. Focused Vitest 5 regression RED 2 before and GREEN 7/7 after, including success/error, moved focus, caller disable, unmount and the Settings caller. Root typecheck, Svelte checks, scoped lint/format and independent GPT-6.1 Sol review pass; the post-rebase test hash difference is line-ending normalization only. Hosted CI covers required broad checks. Native Electron qualification is not claimed.

@antropos17
antropos17 merged commit 8f78937 into master Oct 11, 2026
5 checks passed
@antropos17
antropos17 deleted the codex/action-pending-focus-20261011 branch October 11, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant