Repository navigation
fix(renderer): restore action focus after pending - #913
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Settings notification Test action becomes natively disabled while its async operation runs. In Chromium, keyboard focus falls to BODY and stays there when the button re-enables, so a second Enter does nothing. Shared Action now restores the originally focused button after completion only when it remains connected and enabled and focus has not moved to another control. Native pending/disabled behavior and visual feedback remain unchanged.
Verification: actual Settings UI in Chromium reproduced BODY focus and a no-op second Enter before; after the change focus returns to Test and the second Enter runs the action. Focused Vitest 5 regression RED 2 before and GREEN 7/7 after, including success/error, moved focus, caller disable, unmount and the Settings caller. Root typecheck, Svelte checks, scoped lint/format and independent GPT-6.1 Sol review pass; the post-rebase test hash difference is line-ending normalization only. Hosted CI covers required broad checks. Native Electron qualification is not claimed.