Skip to content

fix(renderer): restore focus after ordinary toast removal - #912

Merged
antropos17 merged 1 commit into
masterfrom
codex/ordinary-toast-focus-20261011
Oct 11, 2026
Merged

antropos17 merged 1 commit into
masterfrom
codex/ordinary-toast-focus-20261011

Conversation

@antropos17

Copy link
Copy Markdown
Owner

Focused ordinary notification dismiss buttons disappear when the user dismisses the toast, its timer expires, or the stack evicts it. Keyboard focus then falls to the document body. Capture focus before the store-driven DOM update and restore the existing Alerts button only when that focused control was removed and focus remains on the body. Focus moved elsewhere and sensitive-banner behavior remain intact.

Verification: the pre-fix component reproduction failed on manual dismiss and expiry; 4 focused regression cases plus 7 existing sensitive-banner cases pass. Root typecheck, Svelte checks, scoped lint/format and diff check pass. Independent GPT-6.1 Sol review found no P1/P2 issue, including after rebase to current master; Git line-ending normalization caused the test working-tree SHA change without changing content. Hosted CI provides the broad required checks. Native Electron keyboard behavior is not claimed from these component tests.

@antropos17
antropos17 merged commit fcf9e2a into master Oct 11, 2026
5 checks passed
@antropos17
antropos17 deleted the codex/ordinary-toast-focus-20261011 branch October 11, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant