Repository navigation
fix(logging): snapshot legacy files before count scan - #905
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
On startup with several legacy daily log files,
scanCountmeasured and opened each path only after the preceding asynchronous read. A concurrent startup flush could append to a later file or rotate its path before the scan reached it. In a real-process reproduction, the logger persisted count 23 with only 22 disk entries; a rotation case omitted legacy entries.The scanner now captures sizes and open descriptors for all eligible files before its first asynchronous yield. It reads only the captured byte ranges from those descriptors and closes them on success and error. The change keeps the existing bounded streaming and logger cancellation semantics.
Verification
no-consolewarning remains.Linux behavior was source-reviewed but not executed locally. Hosted exact-head CI is required before merge. This does not qualify the full logging/rotation acceptance task.