Repository navigation
fix(logger): persist only durable count during seed - #901
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
During legacy log-count seeding, a newly buffered startup entry could be included in the persisted
.countindex before it reached disk. If the process died before flush, the next process could accept a phantom count because the index bytes still matched the durable log. The seed now writes only the streamed disk count, while the public live stats continue to include buffered entries. A flush during an in-flight scan invalidates the seed-index write.Verification
Existing concurrent multi-file scan/rotation behavior and cumulative retention-count semantics remain outside this patch. This is a log-index durability correction, not full crash-reboot enforcement acceptance.