Repository navigation
fix(radar): clear roster focus on Escape - #897
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting an agent through the keyboard-accessible radar roster sets product focus. Pressing Escape on that roster row currently clears the app's selected instance but leaves the marker and row pressed and focused actions visible. Route roster Escape through Radar's existing clear-selection path so both states clear while keyboard focus and later selection still work, including products without a stamped instance.
Verification: the stamped and unstamped regressions failed before the change and passed afterward (6/6 focused tests). Scoped formatting, lint, Svelte checks and diff check passed; the official Svelte autofixer found no new issues. Independent GPT-6.1 Sol review approved the unchanged three-file hashes and source-checked global Escape propagation. Hosted CI will run the five required contexts. This fixes one #24 interaction, not the issue's full visualization scope.