Repository navigation
fix(owner): observe natural exit before forced cleanup - #888
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hosted Windows qualification run 38130675459 reached the installed-owner baseline but recorded supervisorExitCode 259 and refused the expected original-program exit 2. The previous runtime sampled supervisor exit with a zero-time wait during cleanup, then terminated the Job. A native regression reproduced an EOF while the exact child was still active: the old runtime forced cleanup in 9 ms and reported the initial 259 even though the child would naturally exit 2.
The owner now waits only within the original deadline and a two-second cap for the retained supervisor to exit naturally before forced cleanup. It yields the cleanup gate between short polls so concurrent stop/expiry can still terminate promptly. An exit code is emitted only after the exact process handle signals; unknown is null. Expiry or native wait failure still runs mandatory Job cleanup.
The focused Windows native suite passed 8/8 cases, including delayed exit 2, genuine signaled 259, hung child, expired budget, and concurrent Dispose/Expire. ESLint, formatting and diff checks passed. Independent GPT-6.1 Sol review found no actionable P1/P2 findings. The exact hosted SYSTEM route, installed positive and VM remain unqualified; this PR does not claim acceptance.