Repository navigation
fix(rules): reload on YAML addition and removal - #868
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flat and sequence YAML watchers reloaded only on
change. Adding a rule did not activate it, and deleting a sequence rule left its old detection active until another edit or restart. Subscribe the existing filtered reload handlers toaddandunlinktoo.Focused RED tests captured five failures, including a real sequence-engine detection control; ten existing controls passed. The final focused watcher file passes 112 tests with four pre-existing skips. Scoped ESLint, Prettier, main typecheck and diff checks pass. Independent GPT-6.1 Sol review and a final hash check after rebasing onto current master passed. Hosted CI will run the five required contexts.
The implementation retains the existing YAML and underscore filters, flat/sequence isolation, ignoreInitial, symlink settings and atomic handling. Native filesystem timing, packaged Electron behavior and complete issue #39 acceptance remain unqualified.