Repository navigation
fix(qualification): refuse nonzero outer stdio helper exit - #854
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native stdio transport could report
Outcome.Completewhen a helper exited through the outer signaled wait after stdin/output EOF with a nonzero exit code. Route that wait through the existingExchangeExitidentity and exit-code guard so exit 7 is refused during Exchange; keep the positive exit-0 path.A focused Windows same-principal Job-owned fixture forces the outer wait with a real Node helper. The exit-7 case is refused during Exchange, and removing the guard demonstrably lets it reach Verify as Complete. The
test-cloud-guest-stdio.ps1 -MutationControlsrun passed; two independent GPT-6.1 Sol reviews passed. This is transport regression coverage, not cross-account, protected-installation, guest-runtime, or E2 qualification.