Repository navigation
Bound Docker metadata queries when the CLI never calls back - #843
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
When Docker's metadata CLI does not invoke its callback after its own timeout,
refresh()previously remained pending and all later refreshes coalesced onto it. Add an independent three-second watchdog that settles the observation as unavailable, preserves dated candidates, prevents endpoint fallback on timeout, and allows the next eligible refresh. The watchdog,execFiletimeout and shutdown all sendSIGKILLonly to the owned child; late callbacks cannot overwrite a newer observation.Verification
kill.git diff --checkpassed.cd59fe7f04418d00eaf61faa7c8bbfa51f86380b; a reviewer found and verified theSIGKILLcorrection before commit.This is a bounded issue-#8 reliability fix. No live Docker daemon, WSL or Windows VM qualification was performed, and the full issue remains open.