Repository navigation
fix(enforcement): deny impersonated retained caller contexts - #819
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After caller authentication returns, the supervisor thread can acquire an impersonation token before an issued context is checked. Require a clean thread before and after the retained peer/pipe fence so an impersonated check fails before its caller can dispatch an effect.
Add a same-principal Windows native regression with an independently observed thread token and a disposable effect counter. The baseline incorrectly permits one effect; corrected source denies it with zero effects, while clean and reverted-thread controls succeed. The existing primitive remains inactive; full E1.2/E1.5/A1, protected provisioning and resource authority remain unqualified.
Validation:
The initial four-worker full Windows coverage run had five failures in an unchanged enrollment-lease fixture that excludes CallerAdmission.cs. Its original receipt is preserved. The same suite passed 31/31 in isolation with coverage and one worker; final full serial coverage passed. Directory ancestor timestamp sensitivity is a hypothesis requiring a controlled native experiment, without a claimed cause or fix in this PR.
The first CI run passed its runtime gates but failed the counts scanner's interpretation of a test-count phrase in the new document. The wording now keeps the same observed counts without triggering that unrelated source-size match; the scanner and declared repository counts are unchanged.